Repository navigation
fix(runner): accept a single callable aggregator - #233
Merged
helloml0326 merged 1 commit intoNov 12, 2026
Merged
helloml0326 merged 1 commit into
helloml0326 merged 1 commit into
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
helloml0326
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenJudge Version
0.2.5, baseline
6d69c4637be8683f4564481f8c29ac7e549631eb.Description
Passing a function as
GradingRunner(..., aggregators=combine)is accepted by the constructor's declared type, butarun()raisesTypeError: 'function' object is not iterableafter executing the graders.arun_multiple_datasets()fails the same way. Passing[combine]works.Normalize a single callable to a one-element list, as already done for
BaseAggregator. Add public runner regressions usingFunctionGraderand document the supported function form. Existing list, built-in aggregator and no-aggregator behavior is preserved.Validation (Python 3.12.13, macOS):
PYTHONPATH=. python -m pytest tests/runner tests/evaluation_strategy -q: 116 passed.pre-commit run --all-files: every configured hook passed, including the repository's offline pytest selection, pylint, flake8, black/isort and package checks. Process-lifecycle tests require normal system process access; the initial restricted run could not access macOS process information, and the unrestricted run passed.No external service, model response or grader implementation was replaced. Live provider and dataset-quality evaluation are outside the configured offline selection.
AI assistance: OpenAI Codex investigated, implemented, reviewed and ran the checks. This does not assert personal code review or testing by the account owner.
Checklist
pre-commit run --all-files